From 22ed2c6e12354486fe9d2951c7febeac43812e90 Mon Sep 17 00:00:00 2001
From: Brandon Walter <51866976+echoparkbaby@users.noreply.github.com>
Date: Tue, 24 Feb 2026 08:57:57 -0500
Subject: [PATCH] fix: JS syntax error breaking all buttons; add settings
 restart banner
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

app.js: stages.forEach callback in _drawerRenderBurnin was missing its
closing });, causing a syntax error that prevented the entire script
from loading — all click handlers (Short/Long SMART, Burn-In, cancel)
were unregistered as a result.

settings.html: add a prominent yellow restart banner with the docker
command (docker compose restart app) that appears after saving any
system settings that require a container restart to take effect.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 app/static/app.js           |  1 +
 app/templates/settings.html | 11 ++++++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/app/static/app.js b/app/static/app.js
index 8b80216..3d9c5b2 100644
--- a/app/static/app.js
+++ b/app/static/app.js
@@ -969,6 +969,7 @@
           html += '<div class="stage-error-line">' + s.bad_blocks + ' bad block(s) found</div>';
         }
         html += '</div>';
+      });
     } else {
       html += '<div class="drawer-empty">No stage data yet.</div>';
     }
diff --git a/app/templates/settings.html b/app/templates/settings.html
index 55f555b..2578e06 100644
--- a/app/templates/settings.html
+++ b/app/templates/settings.html
@@ -312,6 +312,13 @@
     <button type="button" class="btn-secondary" id="cancel-settings-btn">Cancel</button>
     <span id="save-result" class="settings-test-result" style="display:none"></span>
   </div>
+
+  <!-- Restart required banner — shown after saving system settings -->
+  <div id="restart-banner" style="display:none;margin-top:12px;padding:12px 16px;background:rgba(255,170,0,0.12);border:1px solid var(--yellow);border-radius:8px;color:var(--text-strong)">
+    <strong>&#9888; Container restart required</strong> — system settings are saved but won't take effect until you restart the app container:
+    <pre style="margin:8px 0 0;padding:8px 10px;background:var(--bg-card);border-radius:5px;font-size:12px;color:var(--text-strong);user-select:all">docker compose restart app</pre>
+    <span style="font-size:11px;color:var(--text-muted)">Run this on <strong>maple.local</strong> from <code>~/docker/stacks/truenas-burnin/</code></span>
+  </div>
 </form>
 
 <script>
@@ -365,7 +372,9 @@
                             'poll_interval_seconds','stale_threshold_seconds','allowed_ips','log_level'];
         var savedKeys = data.keys || [];
         var needsRestart = savedKeys.some(function(k) { return systemFields.indexOf(k) >= 0; });
-        showResult(saveResult, true, needsRestart ? 'Saved — restart container to apply system changes' : 'Saved');
+        showResult(saveResult, true, 'Saved');
+        var restartBanner = document.getElementById('restart-banner');
+        if (restartBanner) restartBanner.style.display = needsRestart ? '' : 'none';
       } else {
         showResult(saveResult, false, data.detail || 'Save failed');
       }